jasongilman / proto-repl

A Clojure Development Environment package for the Atom editor
https://atom.io/packages/proto-repl
MIT License
565 stars 50 forks source link

Proto REPL just opens Java Window - Didn't used too #300

Closed broliverparker closed 6 years ago

broliverparker commented 6 years ago

Hi, I recently updated the proto-repl extension inside Atom and before hand everything seemed to work. The repl started inside atom and I could select clojure code to run without any problems. However after the update whenever I try and run the REPL i just get a java window loading up saying i've started the REPL server but I can't do anything in ATOM. Using shift + enter doesn't work and I cant use the hotkeys to select clojure code without getting the error: "This command requires you to position the cursor on a Clojure var."

Image below is the java window that appears, I can't seem to do anything in that either. Didn't have these issues before with my program so I don't think its related to that. Any idea? Thanks!

image

ghost commented 6 years ago

image The same problem :(

thomasiffland commented 6 years ago

Same issue

sashton commented 6 years ago

@broliverparker @tonic4401 @thomasiffland It appears my attempts to kill the REPL JVM in https://github.com/jasongilman/proto-repl/pull/292 didn't work for Windows (I didn't have a Windows install at the time to test). I've since got access to a Windows env and submitted a fix for the issue you are seeing: https://github.com/jasongilman/proto-repl/pull/303

If you are able to, it would be great if you could try that fix out to make sure your problem is resolved.

thomasiffland commented 6 years ago

This fixed the issue for me, thank you!