search

jasongilman / proto-repl

A Clojure Development Environment package for the Atom editor
https://atom.io/packages/proto-repl
MIT License
563 stars 50 forks source link

Don't use detached with Windows; kill process with taskkill #303

Closed sashton closed 6 years ago

sashton commented 6 years ago

Fixes https://github.com/jasongilman/proto-repl/issues/300

It appears that spawning detached in Windows isn't the correct approach. This reverts 'detached' when running in Windows. Also, nodejs and killing the child process also doesn't play nicely in Windows, so this uses the native taskkill command instead.

This commit fixes the issue of the extra terminal window starting in Windows. It also fixes the killing of the JVM process associated with the REPL on REPL-exit (as the original PR intended).

@jasongilman Please take a look at this one soon, as proto-repl is unusable on Windows in the current release.

jasongilman commented 6 years ago

Thanks for submitting this!

sashton commented 6 years ago

Thanks for looking at it so quickly!