search

jasongilman / proto-repl

A Clojure Development Environment package for the Atom editor
https://atom.io/packages/proto-repl
MIT License
563 stars 50 forks source link

Color ANSI codes not rendering with latest version of Ink #310

Open royvandewater opened 6 years ago

royvandewater commented 6 years ago

When using the latest version of ink, ansi color codes from ultra test output render as their escape values, rather than the colors. Downgrading Ink to 0.9.0 fixes this issue. It looks like they switched to a new ANSI conversion library in this commit.

I'm not sure if the problem is in proto-repl, but I figured you might be able to help point me in the right direction. Colors from proto-repl output seem to render fine (like the blue in Refreshing code...).

Example Output

Refreshing code...
No user namespace defined. Defaulting to clojure.tools.namespace.repl/refresh.

:reloading (ink-example.show-ansi-problem-test)
Refresh complete

Testing ink-example.show-ansi-problem-test

FAIL in (show-error) (show_ansi_problem_test.clj:50)
when the test is called and destined to fail

expected: (true? false)
  actual: false

Ran 1 tests containing 3 assertions.
1 failures, 0 errors.
ink-example.show-ansi-problem-test=>
{:type :summary, :fail 1, :error 0, :pass 2, :test 1}

Package Versions


proto-repl 1.4.24
ink 0.9.2
ultra 0.5.2
clojure 1.8.0
lein 2.8.1
java 1.8.0_171
royvandewater commented 6 years ago

Looks like this was fixed here https://github.com/JunoLab/atom-ink/issues/175. They do mention that they're moving to a new version of console and that the current one won't be maintained for much longer.

royvandewater commented 6 years ago

Nevermind, looks like it's still happening :-/