search

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

Makes the lib compatible with Node 4.1.1 #18

Closed hoffmannjan closed 6 years ago

hoffmannjan commented 7 years ago

Tested this on project that I'm working now and everything seems to be OK 👍

jasongin commented 7 years ago

Thanks, and sorry for the delay in getting to this.

I'm not excited about taking on the added step of babel compilation, just to support Node 4. Maybe I could be convinced though. I understand a substantial number of people still run Node 4.

jasongin commented 7 years ago

I think a better solution might be to just change the source code to be Node 4 compatible. I haven't tried, but I think it shouldn't be too hard:

  1. Change all use of let and const to var.
  2. Replace some light use of ES6 Promise with either a promise library, or just change to callbacks.
hoffmannjan commented 7 years ago

Sure, I can do this :). I was only thinking that It might be kind of pain for you to develop this lib in older ES version.

jasongin commented 7 years ago

If this is done, then I can update https://github.com/sandeepmistry/noble/pull/646 to use this package with Node 4 also.

ghost commented 6 years ago

now that node 4.x is EOL is this still worth doing?

ghost commented 6 years ago

I'm pushing to make 6.x the minimum version for the next version of noble btw.

jasongin commented 6 years ago

now that node 4.x is EOL is this still worth doing?

I think not, therefore I'm going to go ahead and close this PR. If anyone objects, please speak up!