Set up node-pre-gyp and appveyor

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings

MIT License

83 stars 45 forks source link

Set up node-pre-gyp and appveyor #21

Closed geovie closed 7 years ago

geovie commented 7 years ago

This adds node-pre-gyp and node-pre-gyp-github to publish prebuilt binaries via Github releases. An appveyor.yaml is also included to automate builts.

Steps to automate builds using appveyor:

sign in to appveyor with your github account. create a new project and select this repo
in github: create a Personal access token with "public_repo" and "repo_deployment"
in appveyor: create a new environment variable NODE_PRE_GYP_GITHUB_TOKEN with the previously created token as value

Fixes #13

jasongin commented 7 years ago

Awesome, thanks for the contribution! I will look over this in more detail, and try running it through AppVeyor, in the next day or two.

jasongin commented 7 years ago

The Node 4 x86 issue is https://github.com/mapbox/node-pre-gyp/issues/209

The comments there suggest that upgrading node-gyp should fix the problem, however our build does upgrade to 3.6.2 which is supposedly new enough. So I applied the other workaround mentioned there, and then the build succeeded.

I'm going to merge this now, along with that workaround.

jasongin commented 7 years ago

Merged as https://github.com/jasongin/noble-uwp/commit/9d89c009973f426f6251b37341062ba63b47c5b8, https://github.com/jasongin/noble-uwp/commit/bf95ec42816c4d4b33783a807d851ff6585eef81, https://github.com/jasongin/noble-uwp/commit/4c8bbf10bac18c701bc0cddea32e0565e1c76fe3

jasongin commented 7 years ago

AppVeyor build for noble-uwp v0.4.0 is running at https://ci.appveyor.com/project/jasongin/noble-uwp/build/1.0.10. If all goes well it should publish the pre-built binaries.

geovie commented 7 years ago

Great, are there any issues left that are blocking the integration in to noble (sandeepmistry/noble#550)? We would be really interested in integrating noble-uwp in to noble!