jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

[BUILD] wrong bindings on npm rebuild with different platform or node api ver #27

Closed farfromrefug closed 7 years ago

farfromrefug commented 7 years ago

There is an issue with the way you load and name bindings in the modules. You always use "binding.node".

Let me explain:

But you end up with bindings built for the wrong version of node. The issue is that in your modules package.json in the binary section, you dont use node_abi

here is a working example: https://github.com/peterbraden/node-opencv/blob/master/package.json

jasongin commented 7 years ago

Yes, I had noticed that problem recently. Your explanation helps me understand the issue better. I'll fix this soon. Thanks!

jasongin commented 7 years ago

Fixed in noble-uwp 0.5.3

farfromrefug commented 7 years ago

that was fast! Thanks