search

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

Noble fallback is unsupported because of os dependency #60

Closed tylergets closed 6 years ago

tylergets commented 6 years ago

https://github.com/jasongin/noble-uwp/blob/master/package.json#L10

Package.json is setup to make sure the platform is windows, however the readme states:

On non-Windows platforms, the benavior is unchanged from noble, while on Windows the UWP bindings are used instead of noble's Bluetooth HCI bindings.

Would you be open to removing the os line? We have multiplatform support in our app and we want to avoid having to check the os and switch between noble and noble-uwp

jasongin commented 6 years ago

You're right, the intention was that it could be referenced on other platforms and just redirect to regular noble there. So that os line should be removed.

jasongin commented 6 years ago

Fixed in version 0.6.2 and published to npm.