Fix electron native build failure in electron 5.0.

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings

MIT License

83 stars 45 forks source link

Fix electron native build failure in electron 5.0. #79

Closed tkomde closed 5 years ago

tkomde commented 5 years ago

This pr resolves electron native build failure in electron 5.0. As V8 is updated in Electron 5.0, replacing deprecated v8::Handle class is needed. https://electronjs.org/blog/nodejs-native-addons-and-electron-5

I only replaced v8::Handle to v8::Local, and confirmed that it work properly with following combinations.

Electron 5.0.1 / Nodejs 12.2
Electron 4.2.0 / Nodejs 12.2
Electron 3.1.9 / Nodejs 12.2

jasongin commented 5 years ago

Thanks for the PR, but actually all these files are from the NodeRT project so it would be better to fix over there, either instead or in addition. If this project ever needs to update the NodeRT version to pick up bugfixes, or to run against a newer Windows SDK to pick up new APIs, then these code files would be regenerated and the changes in this PR would be lost.

tkomde commented 5 years ago

Thank you for your reply. I understand that so I will watch NodeRT status. (Maybe someone will fix it,,,) https://github.com/NodeRT/NodeRT/issues/124