search

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

Electron v9.x compatibility #84

Open nevim42 opened 4 years ago

nevim42 commented 4 years ago

Hi, I have an issue with my application in Electron v9.x using this noble-uwp library. If I try to compile lib for electron (npm rebuild --runtime=electron --target=3.0.8 --arch=x64 --rebuild --disturl=https://atom.io/download/electron --build_from_source=true), then it creates bindings for electron v3.x, but my application wants bindings for electron v9.x. If I try to change target to version 9, then I get errors.

Is there anybody who solved using this library in electron v9.x?

acstacey commented 4 years ago

I have been working on a node v12.x / electron v10.x solution I copied the patch from this repo into a module generated by the newest version of nodert and changed the dependencies to be other updated nodert modules.

It is currently working but is not in any state to be merged back in as I haven't fixed the appveyor or README. It also feels a bit dirty to use optionalDependencies and then check they worked for windows in the install script but I was struggling to find a good solution for them as a platform specific dependency.

https://github.com/acstacey/nodert-win10-cu-windows.devices.bluetooth.genericattributeprofile https://github.com/acstacey/noble-uwp/tree/nodert

Also relevant to #83 and #80