search

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

discoverSomeServices uses discoverAll (slow), and getGattServicesForUuidAsync does not accept valid guids #85

Closed pursual closed 4 years ago

pursual commented 4 years ago

When telling this binding to discover a specific list of service uuids, it instead discovers all, and then filters the results. This is slow if you are working with a device with many services.

I attempted to fix this, but no matter what I throw at getGattServicesForUuidAsync, it always returns "Bad arguments: No suitable overload found".

pursual commented 4 years ago

It doesnt appear that any methods in bindings JS call any of the C methods that accept a guid as an argument, so it is entirely possible that passing a guid to a C method is just broken.

tony-gutierrez commented 4 years ago

Figured out what was going on with the uuids. See https://github.com/jasongin/noble-uwp/pull/86

pursual commented 4 years ago

Closing for now as there is a path forward, or users can use the code in the PR

jasongin commented 4 years ago

I merged the PR. Thanks @tony-gutierrez !