search

jasongin / noble-uwp

Noble (Node.js Bluetooth LE) with Windows 10 UWP bindings
MIT License
83 stars 45 forks source link

Add support for discovering ONLY one service when desired. Fix broken… #86

Closed tony-gutierrez closed 4 years ago

tony-gutierrez commented 4 years ago

… passing of Uuids to winrt C code.

This pull request does 2 things:

  1. Provides an example of how passing uuids to the winrt code is currently broken (albeit currently unused and not causing issues), and provides an addDashesToUuid utility function that corrects this.

  2. Modifies the discoverServices function in bindings.js to use the more efficient getGattServicesForUuid when the user is only requesting ONE service.

jasongin commented 4 years ago

LGTM.

AppVeyor failed on Node v6 for some unrelated reason, but anyway it's probably past time to remove v6 from appveyor.yml (and maybe add v12, v14).