search

jasonhilton / ggfan

Fan plots for plotting distributions in ggplot2
GNU General Public License v2.0
37 stars 5 forks source link

New rstan breaks vignette #12

Open bgoodri opened 1 year ago

bgoodri commented 1 year ago

The rstan package is finally doing the right thing and not listing the ggplot2 package in the Depends field of its DESCRIPTION, but this has had the unfortunate minor side effect of breaking the ggfan_stan.Rmd vignette, which was implicitly relying on rstan to autoload the ggplot2 package. Thus, we are now seeing the error

Quitting from lines 117-128 [convert_to_list] (ggfan_stan.Rmd)
  Error: processing vignette ‘ggfan_stan.Rmd’ failed with diagnostics:
  could not find function "ggplot"

You can overcome this simply by including

library(ggplot2)

in a R chunk near the top of ggfan_stan.Rmd .

R CMD check ggfan_0.1.3.tar.gz has a couple of other unrelated warnings (URL forwarding, comparing a class to a string) that I am sure CRAN would like fixed as soon as possible. We have been trying to get rstan based on the 2.21 Stan release up to 2.26 for a few years now, and we almost got there, but ran into a couple of tiny things like this. So, if you could help us out by making a new CRAN release of ggfan, we would be very grateful.

jasonhilton commented 1 year ago

@bgoodri Thanks very much for this (and for all the work the stan dev team do on rstan more generally). I think I have fixed the various problems and will double check and resubmit to CRAN when I find time to remember how to do that!