search

jasonhinkle / php-gpg

GPG / PGP port written in pure PHP with no binary dependencies
116 stars 28 forks source link

stable build and version number (release) #17

Closed DanielRuf closed 8 years ago

DanielRuf commented 8 years ago

We have two version numbers, 1.1 here https://github.com/jasonhinkle/php-gpg/blob/master/libs/GPG.php#L20 and 1.4.7 here https://github.com/jasonhinkle/php-gpg/blob/master/libs/GPG.php#L33

How do they relate?

I think we can make a release (1.5.0, SemVer style for Packagist) here on GitHub and upate the version number.

raed667 commented 8 years ago

that would make the composer install a little easier if there were at least one stable version :+1:

jasonhinkle commented 8 years ago

line 20 i think was intended to refer to specifically that file GPG.php, whereas line 33 is the "library version"

I think really line 20 can probably just be dropped to avoid confusion. I don't think it's serving any purpose now that the library is in version control, we can all see the revision history without having to keep an arbitrary number in the file.

DanielRuf commented 8 years ago

Created the 1.5.0 release a few minutes ago.

@jasonhinkle possibly ou have to manually update the Packagist project to get the release there. And enabling the Packagist hooks for commits and pull requests on GitHub to automatically update the package on Packagist.

jasonhinkle commented 8 years ago

Cool nice work! I'll check out the best way to do it on packagist, perhaps creating a branch for the version?

jasonhinkle commented 8 years ago

looks like packagist is pulling from master so everything we merge into master will go up. might be the most simple way to deal with it until the point comes where we have a breaking change.

DanielRuf commented 8 years ago

But you have to update it manually if the commit and pull request hooks are not setup on GitHub. Right, at the moment we have the labeled releae on Packagist and the master branch is uptodate =).

jasonhinkle commented 8 years ago

That's what I thought as well but when I went to look at it, it had already updated to 1.5.0. I clicked the update button anyway, but i'm not sure it did anything?

jasonhinkle commented 8 years ago

actually i don't know what's going on! it seems to have picked up the 1.5.0 tag automatically though. is that good enough?

DanielRuf commented 8 years ago

Ok, it seems everything is ok. I am not sure if they do automatic updates once per day or if it was triggered by the push and it was still cached for a few hours. Will take a eye on it when a new commit is pushed.

jasonhinkle commented 8 years ago

I just installed the service hook in github as well just in case, but it seems like it did pick up the tag without me doing that. anyway, i think we should be fully covered now.

DanielRuf commented 8 years ago

Great :+1: