Wrong SQL statement generated by Criteria.php with Order

[alani1]

Hi Jason !

I have a small issue around line 380 of Criteria.php in function Prepare(). In my case $filter->GetOrder($this) returns an empty string. What happens is that we have a , at the end of the order string e.g. "order by MyField desc," which at least mysql does not like. Would it make sense to change that line to :

$this->_order .= $filter->GetOrder($this) ? $orderDelim . $filter->GetOrder($this) : '';

Original code :

// if any of the filters have an order by then add those
    if (is_array($this->Filters)) {
        foreach ($this->Filters as $filter)
        {
            $orderDelim = $this->_order ? ',' : '';
            $this->_order .= $orderDelim . $filter->GetOrder($this);
        }
    }

This seems to solve the issue at least in my case.

regards,

Alain Alain

[jasonhinkle]

I actually just fixed that yesterday so if you update Phreeze that problem will be gone. (I created that bug and it was in the source code for a couple of days)