jasonholtzapple / check_mysql_counters

MySQL Performance Graphs with pnp4nagios
16 stars 10 forks source link

Any chance for 5.7 support? #10

Closed TryTryAgain closed 3 years ago

TryTryAgain commented 8 years ago

We are seeing an issue with the separate Status Variables and System Variables, among other things. Is this in the pipeline?

jasonholtzapple commented 8 years ago

There haven't been any requests and I'm not using it myself. If anyone else would like to see it add a comment please - also mention whether you need Oracle or Percona.

TryTryAgain commented 8 years ago

Thanks! I'm working with a PHP wizard now. We've gotten the checks working, woohoo, now working on getting the graphing working. I'll try and have him fork and add his changes for a possible pull request to merge.

siliconalchemy commented 7 years ago

A quick way to get this to work with 5.7 is to add this to my.cnf:

show_compatibility_56 = on

And hack the regex in check_mysql_counters from: if ((preg_match("/^5\.6\./", $version['VERSION']) and (preg_match("/percona/i", $version['VERSION_COMMENT'])))) { to if ((preg_match("/^5\.[67]\./", $version['VERSION']) and (preg_match("/percona/i", $version['VERSION_COMMENT'])))) {

flcaza commented 7 years ago

Hi, I modify 2 files and if you want to upload it on git it is ok.

check_mysql_counters_57_nagios.txt check_mysql_counters_57_pnp4nagios.txt

File check_mysql_counters_57_nagios.txt rename it to check_mysql_counters_57 and put it in libexec dir of nagios

File check_mysql_counters_57_pnp4nagios.txt rename it to check_mysql_counters_57.php and put it on pnp4nagios directory where you have templates.

Do not forget to add on my.cnf file

show_compatibility_56 = on

wsams commented 6 years ago

Hello, I have a need for check_mysql_counters_57 on MySQL Community Edition. Yesterday I looked into creating one and it appears to be working so I may submit a PR soon unless one is on the way.

jasonholtzapple commented 6 years ago

I'm working on 5.7 Percona but not 5.7 CE so pull request would be welcome!

wsams commented 6 years ago

Great @jasonholtzapple . I looked over what has been done in the percona version and it looks similar to what I've been doing. Hopefully next week I'll have a PR.

wsams commented 6 years ago

Hi @jasonholtzapple , have you ran into any case sensitivity issues? I'm testing against two MySQL 5.7 instances, and for one instance, I had to change,

SELECT * FROM INFORMATION_SCHEMA.GLOBAL_STATUS

to,

SELECT * FROM performance_schema.global_status
jasonholtzapple commented 6 years ago

Short answer, yes ...

wsams commented 6 years ago

@jasonholtzapple , I'm unsure how to do the template. I have some ideas, but maybe you could give me some pointers?

For example, I think $DS[85] comes from one of the references files, but not sure how to generate those?

$def[$num] = rrd::def('sel', $RRDFILE[1], $DS[85], 'AVERAGE');

Update: I also read through http://docs.pnp4nagios.org/pnp-0.6/tpl but still not sure how to generate these templates.

jasonholtzapple commented 6 years ago

@wsams the reference files are created by hand - just an ordered list of all the parameters output by the plugin. They are useful when first creating a template and if you want to add graphs to a previously created template and don't necessarily have access to that version of MySQL. Edit follows - I would just follow one of the existing 5.6 templates for your 5.7 base, or you can wait until I am done with the 5.7 percona one - which will be similar.

wsams commented 6 years ago

@jasonholtzapple , that sounds pretty straight forward. Last September my instance quit charting. We accidentally upgraded from 3 to 4 and didn't notice charting stopped. It's a bit hard for me to test at the moment, but I'm working on it.

jasonholtzapple commented 3 years ago

Native Percona 5.7 support has been merged in. I will not be working on Vanilla 5.7 but will accept merge requests.