Update RPM packaging - Githubissues

jasonish / evebox

Web Based Event Viewer (GUI) for Suricata EVE Events in Elastic Search

https://evebox.org/

MIT License

431 stars 67 forks source link

Update RPM packaging #221

Closed opoplawski closed 1 year ago

opoplawski commented 2 years ago

This tries to do a few things:

Set better permissions on config files
Fix an apparent typo for /etc/sysconfig/evebox
Mark config files as config files so they are not replaced on upgrade
Actually own the real config file This is untested as I don't have the ability to build evebox and evebox RPMs with fpm at the moment.

jasonish commented 2 years ago

This installs config files, rather than just their examples. I'm not sure if I want to do that. By installing "examples", we can overwrite them on upgrade so a valid example is always available. Plus many installation scenarios don't require a configuration file, so I'm not sure this is actually an improvement here.

opoplawski commented 2 years ago

How about this then? I think it's pretty important to install the config files with proper permissions.

jasonish commented 2 years ago

I can add a default config file with the correct permissions, but the file has to be blank I think. The examples are not good as a default.

opoplawski commented 2 years ago

I guess I would suggest a completely commented out version.

jasonish commented 1 year ago

Closing. The RPM and Debian packages will no include a minimal configuration file that suits 90% of most peoples needs.