jasonish / py-idstools

idstools: Snort and Suricata Rule and Event Utilities in Python (Including a Rule Update Tool)
Other
277 stars 85 forks source link

Improvement: rulecat report only if needed #49

Closed sevdog closed 7 years ago

sevdog commented 7 years ago

Rulecat script when using the option --merged always generate a report as you can see in the code, WHICH is logged with level INFO.

If the option -q or --quiet is given this results in an unnecessary execution, because the report is generated but never logged, because the loggin level raises to WARNING.

This code shoul be preceeeded by an if statement that checks if the logging level will permit report display before generating it.

jasonish commented 7 years ago

Thanks. Fix applied. Report will not be generated with --quiet. I might have to rethink the report generation. Its only a half done feature anyways, with the idea of generating a full detailed report.