jasonjgardner / jg-rtx

Minecraft v1.21 HD PBR resource pack. Works with Java and Bedrock shaders.
Creative Commons Attribution Share Alike 4.0 International
116 stars 5 forks source link

The grass_top_normal.png texture in 0.10.0 looks odd when rotated, and other things #6

Closed erich666 closed 3 years ago

erich666 commented 3 years ago

Wha happen?

The grass_top_normal.png texture in 0.8.0 is OK. A little odd looking, perhaps, but it's "rotation invariant." Minecraft normally randomly rotates the grass tops so that they don't show an obvious repeating pattern. If you apply normal maps to these grass tops, I think the normals need to be "unbiased", that is, on average the normals should face up. In 0.10.0 this texture seems to have a definite directional bias, which can be seen when rendering:

image

The normal map in 0.8.0 looks fine:

image

Here's the old normal map compared to the new one:

image

I can't say I know why these display so differently, but there's a definite problem here, one I don't see with most other resource packs that provide normals for grass.

Some other textures that could perhaps use a little love, unless they're purposely this way for some reason:

jasonjgardner commented 3 years ago

I mistakenly left the grass material's normal map channel disabled in Substance Painter. The earlier grass version's normal map shows the ground material's normal map. In the 0.10.0-alpha release, the grass material was "fixed" so that the blades of grass appeared in the normal map output; however, this grass material is probably better suited for higher-resolution textures...

I've created new grass, dirt, and path textures to include in the next release. Here are a few screenshots and a much more tame-looking normal map:

grass_carried_normal New grass_top normal map

Grass screenshot Grass field

Dirt screenshot New dirt, grass sides, and stone

Grass screenshot Grass side closer

Grass screenshot Grass top and sides in daylight

Grass path screenshot Grass and path textures

Grass texture rotation screenshot Arbitrary texture rotation example

Maybe not perfect but certainly an improvement, I think. Feedback welcome.


As for cakes, tripwire hooks, and anvils: Those were intentionally given unique, emissive textures. These are just conceptual/experimental textures I'm playing with while in development.

You might have also noticed the mushroom skin interior textures are emissive and the stems and exterior are metallic. This was by design. The purple lighting is supposed to be similar to blacklights. The metal exterior is supposed to make them appear like some kind of giant sculpture (and it reflects the interior lighting nicely). Swamps and mushroom biomes look pretty neat. Plus, these blocks can be repurposed several ways in Creative mode.

It's brilliant, I tell you.

erich666 commented 3 years ago

It's brilliant, I tell you.

lol. Yeah, I try not to ask too many questions... I've also seen packs with glowing trapdoors (used as lights), concrete, wither roses, and whatnot. Now I want to go visit a swamp.

Anyway, confirmed: the new normals texture looks great - bug's gone. Good deal.

image