jasonjmcghee / rem

An open source approach to locally record and enable searching everything you view on your Mac.
https://rem.ing
MIT License
2.2k stars 63 forks source link

Icon looks kinda weird [relatively] when active in dark mode? #11

Closed ruslanjabari closed 5 months ago

ruslanjabari commented 6 months ago
Screenshot 2023-12-28 at 7 12 35 PM

This probably slipped through the cracks since the Loom demo was in light mode lol

jasonjmcghee commented 6 months ago

I am in dark mode, I think that's based on your background picture.

What's the right way to make this icon? Is there some monochrome approach that inverts appropriately?

Happy to make inverted versions of the status icons. do you know how to make theme specific icons?

ruslanjabari commented 6 months ago

My lazy approach is to normally just create two versions (inverted colors) and match them to the theme of the system.

There's a bunch of ways to detect whether the system is in dark or light mode: https://stackoverflow.com/questions/25207077/how-to-detect-if-os-x-is-in-dark-mode

jasonjmcghee commented 6 months ago

Doesn't seem to have anything to do with light / dark mode

https://github.com/jasonjmcghee/rem/assets/1522149/7ae80d61-9d89-4939-9be8-b69d0cb748d7

jasonjmcghee commented 6 months ago

Answer seems to be this: https://stackoverflow.com/a/64525038