search

jasonjmcghee / rem

An open source approach to locally record and enable searching everything you view on your Mac.
https://rem.ing
MIT License
2.2k stars 63 forks source link

Settings Window Does Not Use MacOS Standard #39

Closed seletz closed 5 months ago

seletz commented 5 months ago

It seems to me that the current settings implementation does not use the standard MacOS UI for settings.

Pressing CMD-, should open application settings, this opens a empty window instead.

This should be an easy fix -- at least in my ObjC days it was pretty simple to add a standard settings window. I might try to get this going, no promises, though -- I've not be doing MaxOS UI development for a very long time. I'll see how this goes.

seletz commented 5 months ago

See also #38

jasonjmcghee commented 5 months ago

Definitely winged it here, didn't realize there's an official route.

Are there any downsides, like a rigid interface to add settings etc.?

Do you have a documentation link?

Regardless, sounds like a great change!

caetano-dev commented 5 months ago

I opened a PR for this! Check #42