search

jasonjmcghee / rem

An open source approach to locally record and enable searching everything you view on your Mac.
https://rem.ing
MIT License
2.18k stars 60 forks source link

fix external monitor bugs, mainly by calling CGDisplayCreateImage without passing the display frame #74

Closed jasonjmcghee closed 5 months ago

jasonjmcghee commented 5 months ago

It's not perfect, but if fixes #55.

It also allows viewing timeline on other monitors and maintains aspect ratio, and allows recording with multiple monitors.

I won't go so far as to say we support multiple monitors yet - but maybe i'll say we are "alpha".

It's ugly, but it "works". It definitely can be done much better.

A better approach might be, if the display changes, start a new video at that resolution.

We either need to integrate automatic scaling into ffmpeg, or handle it how i'm currently doing in this PR.

But I believe this unblocks a lot of users, so I want to get it in.