In #90 a bug was introduced since Search is based off of indexes with the frames table, while the timeline now works on indexes within the chunksFramesView. Therefore, when a search thumbnail is clicked the frames index is passed, but the timeline treats it as a chunksFramesIndex.
This was fixed by converting the frameId to a chunksFramesIndex before passing to the showTimelineView() func. A solution converting the Search functionality to using chunksFramesIndexes was explored, but since all Database retrievals within Search already merge on the chunks table it was not necessary. As well, converting to chunksFramesIndexes would have inhibited the use of pagination.
I noticed that within search results, frames with an offset of 29 did not have thumbnails. I fixed this bug by rounding within the offset calculation while mapping retrieved thumbnails.
In #90 a bug was introduced since Search is based off of indexes with the frames table, while the timeline now works on indexes within the chunksFramesView. Therefore, when a search thumbnail is clicked the frames index is passed, but the timeline treats it as a chunksFramesIndex.
This was fixed by converting the frameId to a chunksFramesIndex before passing to the showTimelineView() func. A solution converting the Search functionality to using chunksFramesIndexes was explored, but since all Database retrievals within Search already merge on the chunks table it was not necessary. As well, converting to chunksFramesIndexes would have inhibited the use of pagination.
I noticed that within search results, frames with an offset of 29 did not have thumbnails. I fixed this bug by rounding within the offset calculation while mapping retrieved thumbnails.