search

jasonjmcghee / rem

An open source approach to locally record and enable searching everything you view on your Mac.
https://rem.ing
MIT License
2.18k stars 60 forks source link

Time blocking Search Results #97

Open cparish312 opened 1 month ago

cparish312 commented 1 month ago

From my experience, it may be more useful to only return one result per time block of some length when searching. Currently, all frames with the text are returned, so this means there are often dozens of frames from really the same "instance" of the found text.

I'm thinking return the most recent frame within a 10 minute block or something like that?

Rewind does something along these lines, and it's pretty helpful!

jasonjmcghee commented 1 month ago

Maybe there's a grouped view? Like each row is a bucket of matching frames in order that are within some time frame?

We skip taking screenshots if OCR returned the exact same result fwiw (assuming the setting is enabled).

cparish312 commented 1 month ago

Grouped view could be good! A little worries it would still be cluttered and you could only have a couple groups at once. Another option could be groups by time and when you click on the frame group it shows all frames within.

Oh cool! Where is that skipping implemented I can't find it?

jasonjmcghee commented 1 month ago

You know, I partially retract - that's what I wrote on a branch, but opted to instead do pixel perfect comparison:

https://github.com/jasonjmcghee/rem/blob/f4f68049a064557bddeb93753f82aa41af776b98/rem/remApp.swift#L341

I ended up not doing the OCR comparison approach as I was concerned about things like photoshop, blender, etc. having high frame loss.