search

jasonkneen / ti-html2as

HTML 2 AttributedString converter for Titanium
Other
64 stars 24 forks source link

Add custom matcher #31

Closed chrisgedrim closed 8 years ago

chrisgedrim commented 8 years ago

This pull request is more of a RFC for the changes.

I need the ability to parse h1-h6's from html into attributed strings, but wanted it to be configurable in case there are more things to add in the future.

FokkeZB commented 8 years ago

Nice idea @chrisgedrim!

chrisgedrim commented 8 years ago

@FokkeZB Can you take a look at the updated code and let me know your thoughts

FokkeZB commented 8 years ago

Looking good! Also great that you've added tests and coverage.

Could you update the README to explain the custom matcher?

chrisgedrim commented 8 years ago

How's that?

FokkeZB commented 8 years ago

I don't see a change? Or was your question what I meant? I mean if you can update https://github.com/FokkeZB/ti-html2as/blob/master/README.md to explain how the custom matcher works then I'll merge and publish new version.

chrisgedrim commented 8 years ago

Helps if you do a push after a commit