search

jasonkuhrt / react-popover

A smart popover component for React
600 stars 240 forks source link

enterExitTransitionDurationMs only applies to the exit animation #107

Closed pjrharley closed 7 years ago

pjrharley commented 7 years ago

Despite the name, the enterExitTransitionDurationMs property only actually applies to the exit animation!

You can see that here in the code:

https://github.com/littlebits/react-popover/blob/v0.4.8/lib/index.js#L338

jasonkuhrt commented 7 years ago

@pjrharley Hmmm yes that indeed seems to be the case! PR welcome for this.

zrwsk commented 7 years ago

Hi,

please check my PR above :)

Kuba

jasonkuhrt commented 7 years ago

Fix released in https://github.com/littlebits/react-popover/releases/tag/0.4.11