search

jasonkuhrt / react-popover

A smart popover component for React
600 stars 240 forks source link

WIP: go to jsx #112

Closed a-x- closed 7 years ago

a-x- commented 7 years ago

closes #100 Deprecated React.createClass React.createElement React.createFactory

jasonkuhrt commented 7 years ago

@a-x- Cool, going to JSX is something I want to do so its great to see this. I would ask that if you continue this PR please try to make as many components pure as you can, but only where its trivial to do so.

a-x- commented 7 years ago

I agree with you, I was just afraid to write PureComponent w/o deep code understanding

jasonkuhrt commented 7 years ago

Superseded by #138. Thanks anyways @a-x-!