search

jasonkuhrt / react-popover

A smart popover component for React
600 stars 253 forks source link

Fix `transitionDuration` property typo #128

Closed timhwang21 closed 7 years ago

timhwang21 commented 7 years ago

Fixes #127.

There can't be a space between the number and 'ms', or it is not recognized as a valid CSS value.

timhwang21 commented 7 years ago

Hey! Just wondering if this could be merged -- it actually results in the latest release of the popover's animations not working at all, and it's super trivial.

jasonkuhrt commented 7 years ago

@timhwang21 Sorry for the delay! I've been very busy with work but also family move and so on lately. I will do my best to look at this soon!! And thanks so much for the contribution.

jasonkuhrt commented 7 years ago

I'll try to cut a release later tonight.

timhwang21 commented 7 years ago

Awesome, thank you!

jasonkuhrt commented 7 years ago

@timhwang21 release cut etc. hope its good now!