search

jasonkuhrt / react-popover

A smart popover component for React
600 stars 240 forks source link

feat(Popover): Add check for onOuterMovement #163

Open fluke opened 6 years ago

fluke commented 6 years ago

Working on a solution for #76

fluke commented 6 years ago

@jasonkuhrt Could you review this PR?

fluke commented 6 years ago

@Kerumen could you check this PR out? Would like to know if there's better ways of managing it.

jasonkuhrt commented 6 years ago

Thanks @kartikluke! I'd like to get some test coverage going on this before merging, ideally. I've been learning how to work with puppeteer recently. I'll bring those learnings back to this project in the future.

fluke commented 6 years ago

@jasonkuhrt I can help out with writing the tests if you'd like.

oyeanuj commented 6 years ago

@jasonkuhrt @kartikluke Any updates here?