search

jasonkuster / merge-bot

An automatic merge robot for the ASF.
http://mergebot-vm.apache.org:8080
Apache License 2.0
2 stars 5 forks source link

Mergebot #6

Closed jasonkuster closed 8 years ago

jasonkuster commented 8 years ago

Commits contain initial project structure (config/, mergebot_poller.py, merge.py) which should just be reviewed for structure, and mergebot.py which should be reviewed for content.

jasonkuster commented 8 years ago

R: @davorbonaci

jasonkuster commented 8 years ago

R: @bjchambers

jasonkuster commented 8 years ago

Ben and I discussed comments on mergebot_poller.py and merge.py and I will incorporate them into future CLs. @bjchambers @davorbonaci - LGTM for mergebot.py?

bjchambers commented 8 years ago

Could you put the comments that are being deferred into either TODOs or a separate doc? If we just leave them in this comment thread, I'm unsure we'll remember all of them.

mergebot.py LGTM

jasonkuster commented 8 years ago

I'll put them in the design doc draft I'm writing up and give you access.

jasonkuster commented 8 years ago

Comments addressed. Merging in.