search

jasonkuster / merge-bot

An automatic merge robot for the ASF.
http://mergebot-vm.apache.org:8080
Apache License 2.0
2 stars 5 forks source link

Mergebot PR #2: mergebot_poller.py #7

Closed jasonkuster closed 8 years ago

jasonkuster commented 8 years ago

Signed-off-by: Jason Kuster jason@google.com

Comments for this PR should be to mergebot_poller.py and github_helper.py.

jasonkuster commented 8 years ago

R: @davorbonaci R: @bjchambers

jasonkuster commented 8 years ago

Comments fixed, thanks. PTAL.

jasonkuster commented 8 years ago

@bjchambers

bjchambers commented 8 years ago

Have you run pylint? Have you looked at https://google.github.io/styleguide/pyguide.html and made sure the docstrings match the styleguide, etc?

jasonkuster commented 8 years ago

Pydoc and other nits fixed. Will probably rework pydoc a bit. Unit tests and other fixes coming soon.

bjchambers commented 8 years ago

Minor nit, but in general LGTM