search

jasonkyuyim / se3_diffusion

Implementation for SE(3) diffusion model with application to protein backbone generation
https://arxiv.org/abs/2302.02277
MIT License
305 stars 50 forks source link

Small question about padding function #11

Closed amorehead closed 1 year ago

amorehead commented 1 year ago

Hello again. Looking at your pad function when torch=True, first off, it looks like one will need to rename this torch function argument to something like torch_inputs to not overwrite the torch module import in this utils.py file. Another thing is, does this torch.pad function exist in PyTorch master yet?

https://github.com/jasonkyuyim/se3_diffusion/blob/420b1fe6d3da53ff17490e5b599df2acca5039e5/data/utils.py#L246

jasonkyuyim commented 1 year ago

Good catch! We never used the torch option so this isn't a bug anywhere but it would raise a namespace error. I've pushed a fix here https://github.com/jasonkyuyim/se3_diffusion/commit/fb350b69ca4349d7b29b19044ecc8627815dafce