C Header Function Name Issue

[GoogleCodeExporter]

[QUOTE]
I've found a little bug in the p3dfft.h - the btran_... and
ftran_... functions, which are written in fortran and are called via
extern... call in the C-header should be commited by p3dfft_btran_... and
p3dfft_ftran_... not just btran_... and ftran_...  in the lines 46-47. It
also would be more consistent if get_dims(...) would be named
p3dfft_get_dims(...) since all of your routines have these p3dfft_
prefix. The odd thing is, that the Intel C compiler icc compiles the
header file just by dropping a warning, that the btran_... and ftran_...
functions are implicitly declared while the Intel C++ compiler icpc won't
do it and droping an error for both function calls, because they are
undefined.
[/QUOTE}

Original issue reported on code.google.com by dan.djc...@gmail.com on 11 May 2010 at 7:15

[GoogleCodeExporter]

Renamed 'get_dims' to 'p3dfft_get_dims' in all test programs

Original comment by masta.p...@gmail.com on 29 Jun 2010 at 6:03

[GoogleCodeExporter]

Another note to the headerfile function-calls:
I don't get the point for what the abort-function is used. 
First: I think it is not valid to define it with "void FORTNAME(abort)()" 
because for my understanding this should be the C/C++ functionbody. The 
function should be only called via FORTNAME or FORT_MOD_NAME in the extern 
block.
Second: There is already an abort() function in fortran and also in C/C++ 
available. So why defining a Fortran-call from C-functions?
//seb

Original comment by sla...@astro.uni-wuerzburg.de on 2 Jul 2010 at 12:01

[GoogleCodeExporter]

To do: remove the abort() function definition and test

Original comment by dan.djc...@gmail.com on 19 Jul 2010 at 12:46

• Changed state: Started

[GoogleCodeExporter]

Original comment by dan.djc...@gmail.com on 22 Jul 2010 at 6:14

• Changed state: Done