jasonleibowitz / react-add-to-calendar-hoc

Simple Unopinionated React Add to Calendar Button. Bring your own components.

http://leibowitz.me/react-add-to-calendar-hoc/docs/

MIT License

70 stars 40 forks source link

Update buttonText proptype to a node #19

Closed vai0 closed 5 years ago

vai0 commented 5 years ago

Allow rendering of any renderable React node rather than limit it to a string. I.e, this will allow for rendering other react components within the button, icons, etc....

codecov-io commented 5 years ago

Codecov Report

Merging #19 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #19   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     24           
=====================================
  Hits           24     24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 435a037...b97dc6a. Read the comment docs.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 46

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.538%

Totals
Change from base Build 44:	0.0%
Covered Lines:	24
Relevant Lines:	24

💛 - Coveralls

jasonleibowitz commented 5 years ago

Out of curiosity what do you want to render as buttonText that isn't a string?

jasonleibowitz commented 5 years ago

Thanks for the PR. Just published v1.0.8 which includes your change.