jasonleibowitz / react-add-to-calendar-hoc

Simple Unopinionated React Add to Calendar Button. Bring your own components.

http://leibowitz.me/react-add-to-calendar-hoc/docs/

MIT License

70 stars 40 forks source link

Remove 'Object.values' for IE11 compatibility #24

Closed KenneyE closed 5 years ago

KenneyE commented 5 years ago

Relates to: #23

I replaced all references of Object.values with an IE11-compatible code snippet based on this SO answer: https://stackoverflow.com/a/43255030/3525808

Testing on BrowserStack seems to work now.

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     24           
=====================================
  Hits           24     24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c87b73b...14ebb93. Read the comment docs.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 52

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.538%

Totals
Change from base Build 51:	0.0%
Covered Lines:	24
Relevant Lines:	24

💛 - Coveralls

jasonleibowitz commented 5 years ago

Nice catch and fix, thanks!