jasonleibowitz / react-add-to-calendar-hoc

Simple Unopinionated React Add to Calendar Button. Bring your own components.

http://leibowitz.me/react-add-to-calendar-hoc/docs/

MIT License

70 stars 40 forks source link

Resolve difference between docs and code #28

Closed bduff9 closed 5 years ago

bduff9 commented 5 years ago

Duration property in the docs says it can be number (2 or 2.5) or string (0200 or 0230). However, currently the proptypes only allow string causing an error in dev when passing a number, even though it works correctly.

codecov-io commented 5 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     24           
=====================================
  Hits           24     24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2eccd4c...6f8c11f. Read the comment docs.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 58

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.538%

Totals
Change from base Build 55:	0.0%
Covered Lines:	24
Relevant Lines:	24

💛 - Coveralls

jasonleibowitz commented 5 years ago

Nice catch, thanks.