jasonleibowitz / react-add-to-calendar-hoc

Simple Unopinionated React Add to Calendar Button. Bring your own components.
http://leibowitz.me/react-add-to-calendar-hoc/docs/
MIT License
70 stars 40 forks source link

[WIP] add documentation for onRequestClose function #32

Closed alaskaa closed 4 years ago

alaskaa commented 4 years ago

Hey :wave:

First of all, thank you for such a great library - it worked beautifully for my usecase and I found it very straightforward to use.

I've noticed you didn't very openly advocate the inbuilt function "onRequestClose" and therefore thought it would be awesome to add it to the docs.

I discovered it more or less by accident, and it provided me with the opportunity to leave the modal and return to a previous modal which was very useful. Happy to rework the PR or add the info at another stage, but I think it would be awesome if it is documented somehow that it can be used to close the dropdowns or modals!

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 64


Totals Coverage Status
Change from base Build 63: 0.0%
Covered Lines: 24
Relevant Lines: 24

💛 - Coveralls
codecov-io commented 4 years ago

Codecov Report

Merging #32 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     24           
=====================================
  Hits           24     24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d4ccba...9ec5d49. Read the comment docs.

jasonleibowitz commented 4 years ago

@alaskaa Apologies for the delayed response. This is a great call out. Thanks for the PR!