jasonleibowitz / react-add-to-calendar-hoc

Simple Unopinionated React Add to Calendar Button. Bring your own components.

http://leibowitz.me/react-add-to-calendar-hoc/docs/

MIT License

70 stars 40 forks source link

Yahoo End Time #40

Open reergymerej opened 3 years ago

reergymerej commented 3 years ago

Bug report

End time for long events does not work with dur value.

Describe the bug

The URL for long events (over ~100 hours) in Yahoo is not constructed correctly. dur does not work. et should be used instead.

To Reproduce

https://calendar.yahoo.com/?v=60&view=d&type=20&title=foo&desc=bar&st=20200515&et=20200829 https://calendar.yahoo.com/?v=60&view=d&type=20&title=foo&desc=bar&st=20200515&dur=0252000

Expected behavior

Use et instead of dur.

Screenshots

System information

Additional context

ezgitetik commented 3 years ago

I intend to fix this issue, but it seems yahoo's end time parametre is not correctly working for timezones:

https://github.com/InteractionDesignFoundation/add-event-to-calendar-docs/blob/master/services/yahoo.md#et

https://stackoverflow.com/questions/32720644/yahoo-calendar-end-time-not-respecting-time-zone

"duration" is advised for durations less than 100 hours, which is not solving my problem