search

jasonlong / geo_pattern

Create beautiful generative geometric background images from a string.
http://jasonlong.github.io/geo_pattern/
MIT License
1.26k stars 89 forks source link

Make sure requested pattern is valid #23

Closed jasonlong closed 10 years ago

jasonlong commented 10 years ago

As a security precaution, this checks that the requested generator is valid before attempting to call it.

/cc @gjtorikian @gregose @andrew

parkr commented 10 years ago

Looks great. :+1:

Not quite sure why you rescue exceptions and abort – won't the exceptions end the process properly? Just curious.

jasonlong commented 10 years ago

I saw that pattern elsewhere while looking for Ruby examples. My Ruby-fu isn't the strongest in a lot of places – would it be better to just remove that block and let it abort normally?

jasonlong commented 10 years ago

Removed the rescue block and merging.