search

jasonlong / geo_pattern

Create beautiful generative geometric background images from a string.
http://jasonlong.github.io/geo_pattern/
MIT License
1.25k stars 88 forks source link

Add Test Tool and QA Tools #38

Closed maxmeyer closed 9 years ago

maxmeyer commented 9 years ago

Hi there, as discussed in #35 here's a PR for basic stuff to setup testing. I also added simplecov, rubocop and inch for qa. I also added some more rake tasks and organize it a bit differently. Hope this was ok.

Next QA-step would be to let rubocop fix most offenses automatically. It does a decent job and is non-destrutive from my experience. There are ~ 200 offenses not fix which might be discussed first and are non-trival to fix.

maxmeyer commented 9 years ago

I also added activesupport to test and development group to make use of strip_heredoc which is quite handy if you have to handle long indented strings. It removes all leading whitespace which makes it easy to use this in tests.

<<-EOS.strip_heredoc
  def blub
    "hello world"
  end
EOS
jasonlong commented 9 years ago

Thanks for working on this @maxmeyer. I'm excited to get a proper test suite in place.

Your PRs go a bit deeper than my Ruby chops are comfortable with, so I'd :heart: to get some input from some other folks as well.

@andrew @ttaylorr @tarebyte @btmills Would any of you guys be willing to help review this as well as #39, #40, and #41?

ttaylorr commented 9 years ago

Thanks @jasonlong, happy to. This PR looks fine to me, and I like the direction it's headed in. I had a few minor, style-related concerns, but besides that everything else looks good.

maxmeyer commented 9 years ago

Better? :-) @ttaylorr

ttaylorr commented 9 years ago

Thanks! I'm happy with this PR, lgtm.

/to @jasonlong

maxmeyer commented 9 years ago

Fixed merge conflict.

maxmeyer commented 9 years ago

And rebased....

jasonlong commented 9 years ago

2 down!

maxmeyer commented 9 years ago

Thanks