search

jasonlong / geo_pattern

Create beautiful generative geometric background images from a string.
http://jasonlong.github.io/geo_pattern/
MIT License
1.26k stars 89 forks source link

Add basic test suite #39

Closed maxmeyer closed 9 years ago

maxmeyer commented 9 years ago

I added a basic test suite and fixed a long that some kind of things.

At first I could not load the library correctly in tests. Therefore I make those requires explicit and place everything at geo_pattern.rb to make it available at once.

This PR is based on the rspec-PR so please merge in that order.

Cheers.

ttaylorr commented 9 years ago

Looks alright to me, but some of the testing behavior that we're introducing worries me a bit. I think once my comments are addressed we'll be good to merge, but I want to look further into a real implementation of SVG, instead of just wrapping a string.

jasonlong commented 9 years ago

Thanks for the help here @ttaylorr, this is great. And thanks @maxmeyer for continuing to get this polished up.

Are we good to merge here or are there some outstanding questions yet?

ttaylorr commented 9 years ago

Always glad to help -- this PR looks ready to ship from my perspective. :)

jasonlong commented 9 years ago

:boom: Boom, 1 down!

maxmeyer commented 9 years ago

Thanks. :+1: