jasonlong / geo_pattern

Create beautiful generative geometric background images from a string.
http://jasonlong.github.io/geo_pattern/
MIT License
1.25k stars 88 forks source link

Rubocop fixes #72

Closed jasonlong closed 3 years ago

jasonlong commented 3 years ago

Ran rubocop -a

jasonlong commented 3 years ago

@tarebyte I'm doing some annual rubocop housekeeping here and have run into some aruba errors that are over my head. Are these things pretty easy to fix up? If it's more than a couple of minutes, please don't bother - I'm not too worried about it.

tarebyte commented 3 years ago

@jasonlong I think it works be making the following change:

diff --git a/spec/support/aruba.rb b/spec/support/aruba.rb
index d86b159..1b003d5 100644
--- a/spec/support/aruba.rb
+++ b/spec/support/aruba.rb
@@ -1,25 +1,3 @@
 # frozen_string_literal: true

-require 'aruba/api'
-require 'aruba/reporting'
-
-# Spec Helpers
-module SpecHelper
-  # Helpers for aruba
-  module Aruba
-    include ::Aruba::Api
-
-    def dirs
-      @dirs ||= %w[tmp rspec]
-    end
-  end
-end
-
-RSpec.configure do |c|
-  c.include SpecHelper::Aruba
-
-  c.before :each do
-    setup_aruba
-    restore_env
-  end
-end
+require 'aruba/rspec'

Looks like everything that support file was doing is now included as part of 1.0

If that doesn't look right I'd just lock the Gemfile to gem 'aruba', '~> 0.14.14'

jasonlong commented 3 years ago

Thanks @tarebyte :bow:. That did the trick for the aruba errors. Now it looks like I have to fix ~90 frozen string literal errors. 🙈

nogweii commented 3 years ago

Closing this since the other PR (#75) covers this as well.