search

jasonlong / geo_pattern

Create beautiful generative geometric background images from a string.
http://jasonlong.github.io/geo_pattern/
MIT License
1.25k stars 88 forks source link

Cutting a new release? Remove the deprecated parameter? #76

Open nogweii opened 3 years ago

nogweii commented 3 years ago

Thanks for merging my changes! What do you think about making a new release for the Ruby 3 compatibility?

It's also been long enough, I think, that the deprecation warning is probably no long necessary. (6 years!) Seems like as good as any time to remove it.

If both were to happen, is that a major version bump, or a minor bump? Not sure if you were following semantic versioning practices with this library.

jasonlong commented 3 years ago

My instinct says that it would still be a minor version bump since there's no functionality change, but an argument could probably be made for a bigger bump due to the Ruby 3 support. 🤔

Would you like me to add you as a maintainer for this project? I hacked the original version together years ago, but most of the follow-up refactoring was done by people with much stronger Ruby-fu than me. I recently added a note to the readme about the project being unmaintained, but if you (or someone else) wanted to help keep things up-to-date I'd happily remove that notice.

nogweii commented 3 years ago

I don't mind being added as a maintainer, though I'm content with the state of the library as it stands. I would focus on compatibility and bug fixes, rather than extending it further.

This is one of those lovely projects that are actually done. No need to push it further, in my mind.

jasonlong commented 3 years ago

This is one of those lovely projects that are actually done. No need to push it further, in my mind.

This is exactly how I see it as well. If you're willing to help keep things up-to-date once in a while in terms of Ruby updates, CI, etc. then that would be perfect. I've added you as a collaborator. Thanks in advance for your help. :bow:

northeastprince commented 1 year ago

@nogweii could you make a new release?