Closing app now delets any changes we made to a game's name, if the game's being played

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Load up a game
1. Edit its name
2. Close iFrotz; close the app entirely
3. Reload it

Alternatively, you can lock the iOS device, or you can flick back and forth 
between apps. Occasionally just going back to the story list causes this 
problem to appear, but closing seems to be the most reliable way to reproduce 
the issue.

What is the expected output or behavior?  What do you see instead?
I'd expect to see the game's name as I'd edited it. Instead, I see the game's 
default name, the one I edited out. Could be the filename, or if it's a blorbed 
file it could be an actual title that I still want to edit (for instance, I 
renamed Savoir Faire to Lavori d'Aracne 1: Savoir Faire. And because of this 
bug I had to do it over and over again. Not fun!).

I'd never noticed this bug before v1.7, I don't think it was there before.

What version of Frotz are you using?
1.7

What device model are you using (e.g., iPhone 5, iPhone 3GS, iPad 4, iPod
Touch 4th gen.)
iPod Touch 5 something or other 

What version of iOS?  6.1, 7.0, etc.)
7.1.something (the latest v7; not using any iOS 8 beta or anything)

Original issue reported on code.google.com by ilprimoc...@gmail.com on 7 Sep 2014 at 9:06

[GoogleCodeExporter]

Update because, isn't it always the way, once you post about it you tinker some 
more and you have corrections to do.

This does happen with both Savoir Faire and Damnatio Memoriae. Not with the 
other couple of games I've tried since I've noticed. So maybe it's to do with 
those games, somehow. I'll keep a look out for more info.

Original comment by ilprimoc...@gmail.com on 7 Sep 2014 at 9:39

[GoogleCodeExporter]

This actually isn't new.  Any game which has an IFmd metadata tag in it's blob 
file will refresh the story details from that metadata any time the the game is 
launched or autorestored.  You just might not have noticed it before because 
many games don't have that tag.
The IFmd metadata is provided by the author of the game and is considered 
canonical, so I didn't figure there was any reason to be overriding it.  I 
could allow edits to take precedence, but that leaves the question of what if 
you want to undo your edits and revert to the metadata contents?  There would 
be no way to get to that once you've edited it without adding another button 
for 'revert' or something.  
Seems kind of not worth bothering with.  But for consistency I should not allow 
you to actually type into those fields in the first place when editing details 
if it's not going to stick.

Original comment by spath...@gmail.com on 8 Sep 2014 at 5:16

[GoogleCodeExporter]

Well, if I edited something once, it can be safely assumed it's easy for me to 
edit it back again. If I'm going to change the title of something, I presumably 
have a reason. For instance, I lump together games by series, series name 
first, so they appear alphabetically and grouped together. "Enchante"; 
"Enchanter 2: Sorcerer"; "Enchanter 3: Spellbreaker". So I would indeed advise 
that edits maybe ought to take precedence; however canonical the game's name 
might be, there might be a reason for a slight edit, and if I want to revert 
it, it's easy to go look up the original name, though if there might be little 
reason to change it in the first place, there'd be even less reason to revert 
it bacl.

"But for consistency I should not allow you to actually type into those fields 
in the first place when editing details if it's not going to stick."

Oh please don't do that. As you see, I do use those fields. And the changes to 
SV and DM seem to have stuck now that I'm actually not actively playing those 
games.

Original comment by ilprimoc...@gmail.com on 8 Sep 2014 at 9:37

[GoogleCodeExporter]

Here's a cute one.

http://anamnese.online.fr/site2/if/inform7/ScarabeeKatana/

It doesn't change the game name *at all*. I go in, I change the name, I come 
out, it's still as it was. And what it was is the game's filename: Otto 
Scarabeekatana. Surely not intended behaviour.

The problem only exists in the Glulx version, ZCode version of this game I can 
rename.

Curiously, if I rename it, play it, play something else, then return to it, I 
can see at the bottom "Autorestoring ***", where *** is the name I changed to, 
instead of the persisting "Otto etc".

Original comment by ilprimoc...@gmail.com on 8 Sep 2014 at 11:24

[GoogleCodeExporter]

Fixed in r349.
Editing metadata now overrides blorb data.
Editing metadata fields to be empty will being back blorb metadata entries if 
they exist.

Added special check for double extension (e.g. .gblorb.blb) when deriving 
metadata dictionary key from story path, so games like 
otto_scarabeekatana.gblorb.blb don't fail.

Original comment by spath...@gmail.com on 9 Sep 2014 at 6:41

• Changed state: Fixed-Pending

[GoogleCodeExporter]

Fixed in App Store released version 1.7.1.

Original comment by spath...@gmail.com on 20 Oct 2014 at 4:54

• Changed state: Fixed