search

jasonlvhit / gocron

A Golang Job Scheduling Package.
BSD 2-Clause "Simplified" License
3.46k stars 345 forks source link

Proposal: Please start using Semantic Versioning #162

Closed KateGo520 closed 4 years ago

KateGo520 commented 4 years ago

I found that this project already supports Go modules. But sadly, the tags doesn't follow Semantic Versioning, which means that all tags of this project will be ignored by Go modules and replaced by pseudo-versions, go get acts weirdly when tags are not in that form. It would be great to have the tagged release be named in the format vX.X.X format so that go mod can read it. 

    github.com/jasonlvhit/gocron v0.0.0-20200423141508-ab84337f7963

Else the mod file shows something like github.com/jasonlvhit/gocron v0.0.0-20200423141508-ab84337f7963 which is not very readable and difficult to upgrade. It’s hard to verify which version is in use. This is not conducive to version control

So, I propose this project to follow Semantic Versioning in future versions. For example, v1.0.1, v2.0.0, v3.1.0-alpha, v3.1.0-beta.2etc.

KateGo520 commented 4 years ago

@Streppel @Arjunmahishi Could you help me review this issue? Thx :p

Streppel commented 4 years ago

Hi @KateGo520! Absolutely, we can fix this here. Be aware, though, that we migrated to a new repo linked in the readme and we are working collectively over there, be sure to check it out!

Streppel commented 4 years ago

Updated semver :-)

KateGo520 commented 4 years ago

@Streppel OK, I see the new link. Thank you!