Colors on Android 4.x and 5

[hohae]

I'm using the "light" theme. It works perfectly on Android 6 and higher. But on Android 4 and 5 I get strange renderings: Black font on black background or at least a very low contrast. Any hints?

THX, Holger

[jasonmamy]

I don't have access to Android 4/5, but it's gotta be close to these lines of code:

https://github.com/jasonmamy/cordova-wheel-selector-plugin/blob/master/src/android/com/wellseek/cordova/SelectorCordovaPlugin.java#L216

Try messing with that and see if it makes a difference? I know it wasn't easy to change those colors in code (they wanted you to do it in android manifest which really doesn't easily exist in ionic), so it's kinda hacky in there.

On Tue, Jan 9, 2018 at 12:33 AM, hohae notifications@github.com wrote:

I'm using the "light" theme. It works perfectly on Android 6 and higher. But on Android 4 and 5 I get strange renderings: Black font on black background or at least a very low contrast. Any hints?

THX, Holger

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxqbaVFhZENUU5DJ-xI2vZyth7SgBks5tIyRygaJpZM4RXejq .

[hohae]

Jason,

I’ve found the problem. The theme you’re using has been introduced in Android 5.1. For versions before 5.1, it falls back to default themes. Those two changes fix the behavior in all Android versions.

[cid:image002.png@01D3A963.A081BD70]

[cid:image001.png@01D3A963.30C1F3B0]

I’ve also been facing some problems with JS code in selectorplugin.js in the context of a Cordova app. I had to change the following lines:

[cid:image003.png@01D3A964.0BE44790]

Do you want to integrate that code into your code? Or should I run this in my own copy of your plugin?

Regards, Holger

From: jasonmamy [mailto:notifications@github.com] Sent: Mittwoch, 10. Januar 2018 20:31 To: jasonmamy/cordova-wheel-selector-plugin cordova-wheel-selector-plugin@noreply.github.com Cc: Holger Häffelin Holger.Haeffelin@arcworx.net; Author author@noreply.github.com Subject: Re: [jasonmamy/cordova-wheel-selector-plugin] Colors on Android 4.x and 5 (#20)

I don't have access to Android 4/5, but it's gotta be close to these lines of code:

https://github.com/jasonmamy/cordova-wheel-selector-plugin/blob/master/src/android/com/wellseek/cordova/SelectorCordovaPlugin.java#L216

Try messing with that and see if it makes a difference? I know it wasn't easy to change those colors in code (they wanted you to do it in android manifest which really doesn't easily exist in ionic), so it's kinda hacky in there.

On Tue, Jan 9, 2018 at 12:33 AM, hohae notifications@github.com<mailto:notifications@github.com> wrote:

I'm using the "light" theme. It works perfectly on Android 6 and higher. But on Android 4 and 5 I get strange renderings: Black font on black background or at least a very low contrast. Any hints?

THX, Holger

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxqbaVFhZENUU5DJ-xI2vZyth7SgBks5tIyRygaJpZM4RXejq .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-356710889, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APPmUTZttNbs_mNKWWnYaPhWjam8PCj3ks5tJQ_egaJpZM4RXejq.

[jasonmamy]

If you can do a pull request with the changes then I can merge them into the main branch and spin off another release, that would be the easiest.

On Feb 19, 2018 12:29 AM, "hohae" notifications@github.com wrote:

Jason,

I’ve found the problem. The theme you’re using has been introduced in Android 5.1. For versions before 5.1, it falls back to default themes. Those two changes fix the behavior in all Android versions.

[cid:image002.png@01D3A963.A081BD70]

[cid:image001.png@01D3A963.30C1F3B0]

I’ve also been facing some problems with JS code in selectorplugin.js in the context of a Cordova app. I had to change the following lines:

[cid:image003.png@01D3A964.0BE44790]

Do you want to integrate that code into your code? Or should I run this in my own copy of your plugin?

Regards, Holger

From: jasonmamy [mailto:notifications@github.com] Sent: Mittwoch, 10. Januar 2018 20:31 To: jasonmamy/cordova-wheel-selector-plugin <cordova-wheel-selector- plugin@noreply.github.com> Cc: Holger Häffelin Holger.Haeffelin@arcworx.net; Author < author@noreply.github.com> Subject: Re: [jasonmamy/cordova-wheel-selector-plugin] Colors on Android 4.x and 5 (#20)

I don't have access to Android 4/5, but it's gotta be close to these lines of code:

https://github.com/jasonmamy/cordova-wheel-selector-plugin/ blob/master/src/android/com/wellseek/cordova/SelectorCordovaPlugin.java# L216

Try messing with that and see if it makes a difference? I know it wasn't easy to change those colors in code (they wanted you to do it in android manifest which really doesn't easily exist in ionic), so it's kinda hacky in there.

On Tue, Jan 9, 2018 at 12:33 AM, hohae <notifications@github.com<mailto: notifications@github.com>> wrote:

I'm using the "light" theme. It works perfectly on Android 6 and higher. But on Android 4 and 5 I get strange renderings: Black font on black background or at least a very low contrast. Any hints?

THX, Holger

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxqbaVFhZENUU5DJ- xI2vZyth7SgBks5tIyRygaJpZM4RXejq .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-356710889, or mute the threadhttps://github.com/notifications/unsubscribe- auth/APPmUTZttNbs_mNKWWnYaPhWjam8PCj3ks5tJQ_egaJpZM4RXejq.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-366618651, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxshcZwSXA6erNR3aHJLWUj4C09E9ks5tWTDMgaJpZM4RXejq .

[okaufmann]

I have the same Problem but am not a Java developer. Any tips how to fix this (then I would give it a try 🙈)

Here is a Example how it looks now:

[jb280]

Did Holger's fix for older android versions get integrated in? (or posted in a readable form)? I'm guessing the images he posted in his email didn't make it here? (ie. [cid:image002.png@01D3A963.A081BD70]). I'm seeing the black selector & text on older android phones. Thanks.

[jasonmamy]

No, he never did a pull request, so there was nothing to merge back in? Holger, can you add a pull request with your changes so we can push it back into the main code line? Thanks!

On Sat, Jun 9, 2018 at 5:27 AM, Jeff Busma notifications@github.com wrote:

Did Holger's fix for older android versions get integrated in? (or posted in a readable form)? I'm guessing the images he posted in his email didn't make it here? (ie. [cid:image002.png@01D3A963.A081BD70]). I'm seeing the black selector & text on older android phones. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-395965522, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxqKH_IItzxbjMZTlLMXRazuG7gQ_ks5t678bgaJpZM4RXejq .

[hohae]

I have to do some cleanup in my code first before adding a PR. There were more problems in Android regarding font sizes of the button and title label and the selected and non-selected items. I’ve just done quick and dirty fixes for my app.

From: jasonmamy notifications@github.com Sent: Monday, 11 June 2018 19:37 To: jasonmamy/cordova-wheel-selector-plugin cordova-wheel-selector-plugin@noreply.github.com Cc: Holger Häffelin Holger.Haeffelin@arcworx.net; Author author@noreply.github.com Subject: Re: [jasonmamy/cordova-wheel-selector-plugin] Colors on Android 4.x and 5 (#20)

No, he never did a pull request, so there was nothing to merge back in? Holger, can you add a pull request with your changes so we can push it back into the main code line? Thanks!

On Sat, Jun 9, 2018 at 5:27 AM, Jeff Busma notifications@github.com<mailto:notifications@github.com> wrote:

Did Holger's fix for older android versions get integrated in? (or posted in a readable form)? I'm guessing the images he posted in his email didn't make it here? (ie. [cid:image002.png@01D3A963.A081BD70]). I'm seeing the black selector & text on older android phones. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-395965522, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9UxqKH_IItzxbjMZTlLMXRazuG7gQ_ks5t678bgaJpZM4RXejq .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-396324175, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APPmUeDXILbcJcD4L2IhA_yyW8YP-rjFks5t7qq5gaJpZM4RXejq.

[conormag]

@jasonmamy any way you can post the images @hohae sent? really need to know that fix!

[jasonmamy]

I would, but the pics never were attached, all I saw was:

I’ve found the problem. The theme you’re using has been introduced in Android 5.1. For versions before 5.1, it falls back to default themes. Those two changes fix the behavior in all Android versions.

[cid:image002.png@01D3A963.A081BD70]

[cid:image001.png@01D3A963.30C1F3B0]

I’ve also been facing some problems with JS code in selectorplugin.js in the context of a Cordova app. I had to change the following lines:

[cid:image003.png@01D3A964.0BE44790]

On Wed, Jun 27, 2018 at 6:12 AM, Conor Maguire notifications@github.com wrote:

@jasonmamy https://github.com/jasonmamy any way you can post the images @hohae https://github.com/hohae sent? really need to know that fix!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-400666187, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9Uxoyv8jZ2mZHkUap_0pxL9jX-D5Ocks5uA4SmgaJpZM4RXejq .

[hohae]

Hi,

please find attached my current code. It works but is not yet production quality – therefore no PR yet from me.

Regards, Holger

From: jasonmamy notifications@github.com Sent: Thursday, 28 June 2018 18:48 To: jasonmamy/cordova-wheel-selector-plugin cordova-wheel-selector-plugin@noreply.github.com Cc: Holger Häffelin Holger.Haeffelin@arcworx.net; Mention mention@noreply.github.com Subject: Re: [jasonmamy/cordova-wheel-selector-plugin] Colors on Android 4.x and 5 (#20)

I would, but the pics never were attached, all I saw was:

I’ve found the problem. The theme you’re using has been introduced in Android 5.1. For versions before 5.1, it falls back to default themes. Those two changes fix the behavior in all Android versions.

[cid:image002.png@01D3A963.A081BD70]

[cid:image001.png@01D3A963.30C1F3B0]

I’ve also been facing some problems with JS code in selectorplugin.js in the context of a Cordova app. I had to change the following lines:

[cid:image003.png@01D3A964.0BE44790]

On Wed, Jun 27, 2018 at 6:12 AM, Conor Maguire notifications@github.com<mailto:notifications@github.com> wrote:

@jasonmamy https://github.com/jasonmamy any way you can post the images @hohae https://github.com/hohae sent? really need to know that fix!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-400666187, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9Uxoyv8jZ2mZHkUap_0pxL9jX-D5Ocks5uA4SmgaJpZM4RXejq .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/20#issuecomment-401100349, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APPmUSZ8Tj7UbxQtFxqDOzyFr2VeFaoyks5uBQiugaJpZM4RXejq.

[isaqib23]

I solved this issue by changing android app theme. see

Follow these steps for changing android app theme:

1. go to your-project\platforms\android\app\src\main\AndroidManifest.xml
2. find @android:style/Theme.DeviceDefault.NoActionBar & change this with @android:style/Theme.Material.Light.NoActionBar
3. re-generate your apk file