search

jasonmamy / cordova-wheel-selector-plugin

Wheel selector for Cordova (Android/iOS)
MIT License
65 stars 36 forks source link

Compilation error due to current examples folder #51

Closed hoangdung-nguyen-6791 closed 5 years ago

hoangdung-nguyen-6791 commented 5 years ago

Although PR #50 has been merged, it did not seem to take effect. Please consider triggering a new package build and release (possibly 1.0.2) which actually exclude the examples folder after all. Many thanks, @jasonmamy.

jasonmamy commented 5 years ago

I did a clean sync from github (deleted my local dir), revved new version to 1.1.3. Ran npm pack and verified that there were no examples in the published package (the .npmignore file contains /examples). See if this helps.

On Fri, May 31, 2019 at 1:52 AM Nguyen Hoang Dung notifications@github.com wrote:

Although PR #50 https://github.com/jasonmamy/cordova-wheel-selector-plugin/pull/50 has been merged, it did not seem to take effect. Please consider triggering a new package build and release (possibly 1.0.2) which actually excludes the examples folder after all. Many thanks, @jasonmamy https://github.com/jasonmamy.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/51?email_source=notifications&email_token=ACPVJRU4LIWAZWZLMLK6QOLPYDRORA5CNFSM4HRWQ562YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GW465ZQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVJRX6PAEX72XFUMVQPS3PYDRORANCNFSM4HRWQ56Q .

hoangdung-nguyen-6791 commented 5 years ago

Thanks, @jasonmamy. I've just checked and it's vanished for now.