search

jasonmamy / cordova-wheel-selector-plugin

Wheel selector for Cordova (Android/iOS)
MIT License
65 stars 36 forks source link

Text not showing up on android 10 #56

Closed zheng17 closed 4 years ago

zheng17 commented 4 years ago

image Failed to set text color in Android 10 Devices.

I fork the branch and made one quick fix, please merge that.

https://github.com/zheng17/cordova-wheel-selector-plugin/commit/80c1ecb69fc22ea7148f8d6a615eea605fdfe9ae#diff-8bc41c3962ff62f78ac188b0c90cb9c6

jasonmamy commented 4 years ago

Great! Do you think you could create a 'pull request' so I can merge it seamlessly into the code base?

Thanks, Jason

On Tue, Feb 18, 2020 at 3:43 PM Zheng notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/25708672/74787825-c05a0e00-5275-11ea-8d88-a1d3eb38999a.png Failed to set text color in Android 10 Devices.

I fork the branch and made one quick fix, please merge that.

zheng17@80c1ecb#diff-8bc41c3962ff62f78ac188b0c90cb9c6 https://github.com/zheng17/cordova-wheel-selector-plugin/commit/80c1ecb69fc22ea7148f8d6a615eea605fdfe9ae#diff-8bc41c3962ff62f78ac188b0c90cb9c6

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/56?email_source=notifications&email_token=ACPVJRTIP7YYYAQR3QEMEKDRDRXCXA5CNFSM4KXOSY72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOPGHHQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPVJRTJOJLP5VYR27YXEIDRDRXCXANCNFSM4KXOSY7Q .

zheng17 commented 4 years ago

The pull request has been submitted. Thanks.

jasonmamy commented 4 years ago

Thanks, everything is updated (new release 1.1.5) and published to npm.

On Tue, Feb 18, 2020 at 3:55 PM Zheng notifications@github.com wrote:

The pull request has been submitted. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/56?email_source=notifications&email_token=ACPVJRT7C2PZU3QWM2UT2K3RDRYOPA5CNFSM4KXOSY72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMFZ3IY#issuecomment-587963811, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPVJRUMCT367RGZ5OFP7T3RDRYOPANCNFSM4KXOSY7Q .