search

jasonmccreary / laravel-test-assertions

A set of helpful assertions when testing Laravel applications.
321 stars 34 forks source link

TestResponse and FactoryBuilder macros #16

Open devmsh opened 4 years ago

devmsh commented 4 years ago

Hi,

I don't know if TestResponse macros can be part of the package or it's out of your interests? for example, I have a assertJsonPaths and assertPaginated witch I have several use cases for them when I develop APIs.

If you interested let me know to open RP for some of them, and if you prefer to have each one as a separate PR or we can add a bulk of macros together.

Sometimes I also add some macros to the FactoryBuilder like a data macro as a shortcut for factory(Model::class)->make()->toArray() which is also useful for some use cases.

Have a nice day and keep safe 👍

jasonmccreary commented 4 years ago

Absolutely. The more the merrier.

I only ask that you PR them separately and make a quick effort to list them in the README.

devmsh commented 4 years ago

I will add the first one tomorrow, and once we agreed about the format and merged the first PR, the rest will be easier 👍

jasonmccreary commented 4 years ago

@devmsh any process on this?