search

jasonmccreary / laravel-test-assertions

A set of helpful assertions when testing Laravel applications.
321 stars 34 forks source link

Adding Test Scaffolding and first two tests #26

Closed simonvomeyser closed 1 year ago

simonvomeyser commented 4 years ago

Hey-ho Mr. JMac!

Really dig this package and the easier approach to testing validation rules! :)

I was actually trying to work on another PR but noticed there are no tests... to test... the tests. #testception

Created the scaffolding and an hopefully not too mind bending approach to check, if the first two trait assertions do what they say they do.

Just wanted to check if you are interested in this.

Let me know and keep up the good work 💪 Simon vom Eyser

jasonmccreary commented 4 years ago

Thanks for this. I'd like to use a tests/fixtures folder for the "Dummy" classes.

simonvomeyser commented 4 years ago

Happy you like it! Change makes sense, done :)