search

jasonmccreary / laravel-test-assertions

A set of helpful assertions when testing Laravel applications.
321 stars 34 forks source link

assertNotSoftDeleted declaration breaks in Laravel 8.62 #30

Closed shawnhooper closed 3 years ago

shawnhooper commented 3 years ago

When Laravel Shift upgraded my repo to Laravel 8.62, this error appears in my build:

PHP Fatal error:  Declaration of JMac\Testing\Traits\AdditionalAssertions::assertNotSoftDeleted(Illuminate\Database\Eloquent\Model $model) must be compatible with Illuminate\Foundation\Testing\TestCase::assertNotSoftDeleted($table, array $data = [], $connection = null, $deletedAtColumn = 'deleted_at')
jasonmccreary commented 3 years ago

Yeah, this was just released 2 hours ago. This package will need to be updated to delegate or remove this method.

shawnhooper commented 3 years ago

@jasonmccreary 👍 Fair enough - Just wanted to report it. Love these additional assertions :)

jasonmccreary commented 3 years ago

@shawnhooper, can you target dev-v2 and see if it's all compatible? If so, I'll merge and tag as 2.0.

shawnhooper commented 3 years ago

@jasonmccreary Confirmed, that did built properly. Thank you!

jasonmccreary commented 3 years ago

@shawnhooper, 2.0.0 has been tagged. Unfortunately since this was tagged after Shift's automation, most will need to manually update their dependency to ^2.0 when updating to Laravel 8.62.